Stabilize the api proto descriptors in swarmkit #2349
Conversation
Signed-off-by: He Xiaoxi <[email protected]>
Signed-off-by: He Xiaoxi <[email protected]>
|
@stevvooe PTAL, thanks! |
tossmilestone
force-pushed
the
stabilize-api
branch
8 times, most recently
from
775003a
to
086831b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2349 +/- ##
=========================================
- Coverage 60.1% 60.01% -0.1%
=========================================
Files 128 128
Lines 26177 26177
=========================================
- Hits 15734 15709 -25
- Misses 9045 9070 +25
Partials 1398 1398 |
Protobuild.toml
Outdated
|
|
||
| [[descriptors]] | ||
| prefix = "github.com/docker/swarmkit/protobuf/plugin" | ||
| target = "protobuf/plugin/plugin.pb.txt" |
There was a problem hiding this comment.
No need to stabilize the plugin API, they are only used here.
There was a problem hiding this comment.
Ok，I will remove it
There was a problem hiding this comment.
@stevvooe updated, please review again
tossmilestone
force-pushed
the
stabilize-api
branch
from
086831b
to
1540992
Compare
|
LGTM |
There was a problem hiding this comment.
@tossmilestone @stevvooe do we need to include the api/api.pb.txt file in the repo?
|
@nishanttotla That is the entire point of the PR. ;) The idea is that symbol changes in Please see the README in containerd. That explains it more thoroughly. Perhaps, this PR should include a similar readme. |
|
@stevvooe I will add a similar README in containerd later to clarify how to use it. |
Signed-off-by: He Xiaoxi <[email protected]>
Use the API stability tool of protobuild to stabilize the proto descriptors in swarmkit. It will generate:
api/api.pb.txtforapipackageSigned-off-by: He Xiaoxi [email protected]